dfaure added a comment.
Please expand the commit log. Like "Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON" INLINE COMMENTS > KF5CoreAddonsConfig.cmake.in:10 > + # 3.10+ lets us provide more macro names that require automoc. > + # Remove this when depending on a Frameworks or ECM version that solves > this upstream. > + list(APPEND CMAKE_AUTOMOC_MACRO_NAMES "K_PLUGIN_FACTORY_WITH_JSON" > "K_PLUGIN_FACTORY") Remove this particular line of the comment, it makes no sense here. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9334 To: mlaurent, dfaure Cc: #frameworks
