kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land.
Yes. Makes sense to me. INLINE COMMENTS > KF5ConfigMacros.cmake:98 > > + set_property(SOURCE ${_header_FILE} PROPERTY SKIP_AUTOMOC TRUE) # > don't run automoc on this file > + set_property(SOURCE ${_src_FILE} PROPERTY SKIP_AUTOMOC TRUE) # don't > run automoc on this file Use `set_source_files_properties(...)` instead, cf. https://phabricator.kde.org/R249:6e3b7084356666cc7747ea83a3afea4647c2d48b REPOSITORY R237 KConfig BRANCH remove_cmake_warning REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks