renatoo accepted this revision.
renatoo added a comment.

  Looks good and work as expected

INLINE COMMENTS

> kfileplacesview.cpp:766
> +    }
>      if (!clickOverHeader && index.isValid()) {
>          if (!placesModel->isDevice(index)) {

I think that you can replace

if (!clickOverHeader && index.isValid()) {

with

else if (index.isValid()) { 
....
}

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8450

To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks

Reply via email to