kfunk added a comment.
In https://phabricator.kde.org/D3987#174960, @mkoller wrote: > I just found out that this change introduced wrong replacements. It did not, the changes are correct, though they're probably not what everyone expects. Please read through the comments in this Diff, this issue has been discussed in length already. tl;dr: Proposed resolution of this "problem": I'd replace `return nullptr` in your cases with `return {}` or just leave it as-is. > The changes in frameworks/kimageformats/src/imageformats like the following are incorrect, since the return type is not a pointer but an enum flags type, so it should still be 0, not nullptr. > > @@ -337,10 +337,10 @@ QImageIOPlugin::Capabilities EPSPlugin::capabilities(QIODevice *device, const QB > > return Capabilities(CanRead | CanWrite); > } > if (!format.isEmpty()) { > > - return 0; + return nullptr; } if (!device->isOpen()) { > - return 0; + return nullptr; } > > Capabilities cap; REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D3987 To: kfunk, #frameworks, dfaure, kossebau Cc: mkoller, skelly, kossebau, dfaure, graesslin
