anthonyfieroni added inline comments.

INLINE COMMENTS

> kjob.cpp:98
> +{
> +    QTimer::singleShot(delay, this, SLOT(start()));
> +}

Use new syntax

  QTimer::singleShot(delay, this, &KJob::start);

> kjob.h:182
> +     */
> +    Q_SCRIPTABLE virtual void start(int delay);
> +

You cannot add a virtual function it will break ABI compatibility.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D8999

To: rjvbb, dfaure
Cc: anthonyfieroni, #frameworks

Reply via email to