simgunz added inline comments. INLINE COMMENTS
> dfaure wrote in kopenwithdialog.cpp:463 > Use the member var instead of casting. Segmentation fault happens if I use the member var. Accessing the member var is the cause of the fault, because even `qDebug() << d->m_proxyModel` generates the same error. It is not clear to me why. > dfaure wrote in kopenwithdialog.cpp:830 > Could the view have a method that returns the proxymodel (possibly as a > QSortFilterProxyModel* if we don't actually need a subclass-typed pointer), > to avoid this cast? > Such casts make refactoring more difficult, moving problems from compile-time > to runtime. Ok I'll add a method. > dfaure wrote in kopenwithdialog.cpp:1108 > All this "return false" cascade isn't really needed, a single return false at > the end would do the job, or even better, calling the eventFilter method of > the base class, just in case that's implemented for other reasons. Yes, the cascade of return false doesn't make sense. You mean calling eventFilter of QDialog instead of returning false at the end? eventFilter of QDialog is virtual. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks
