dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > kfileplacesmodeltest.cpp:804 > + > + // check if url list is corret after insertion > + QStringList urls; typo: correct > kfileplacesmodeltest.cpp:812 > + > + // check if the new ulr was inserted int the right position (end of > "Remote" section) > + QTRY_COMPARE(spy_inserted.count(), 1); typo: URL typo: *in* the > kfileplacesmodeltest.cpp:819 > + > + // check if the new ulr has the right group "Remote" > + const QModelIndex index = m_places->index(expectedRow, 0); typo: URL > kfileplacesitem_p.h:48 > PlacesType = 0, > - RecentlySavedType = 1, > - SearchForType = 2, > - DevicesType = 3, > - RemovableDevicesType = 4 > + RemoteType = 1, > + RecentlySavedType = 2, If the actual numbers don't matter (as shown by this commit), why do we even number these explicitly? I would just remove all the =0, =1, =2... values. It will make the diff smaller in the next such commit ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks
