mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesviewtest.cpp:2
> +/* This file is part of the KDE project
> + Copyright (C) 2007 Kevin Ottens <er...@kde.org>
> +
? I don't think that you are kevin ottens :) and we are in 2017 :)
> kfileplacesviewtest.cpp:20
> +
> +#include <QtCore/QObject>
> +#include <QtCore/QDebug>
QtCore/ is not necessary
> kfileplacesviewtest.cpp:30
> +
> +#include <QtTest/QtTest>
> +#include <QtTest/QSignalSpy>
QtTest/ not necessart too
> kfileplacesviewtest.cpp:70
> +}
> +void KFilePlacesViewTest::testConvertUrl_data()
> +{
new line before it
> kfileplacesviewtest.cpp:111
> +
> + QSignalSpy urlChangedSpy(&pv, SIGNAL(urlChanged(QUrl)));
> + const QModelIndex targetIndex = pv.model()->index(row, 0);
use new connect api for QSignalSpy
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin
Cc: ervin, usta, mlaurent, dvratil, ngraham, #frameworks
