leinir added a subscriber: sitter. leinir added a comment.
Damn... Well spotted, @kossebau. Right, so immediate (at least temporary solution) to make things not broken would annoyingly enough be to revert the patch, yes... I am now thinking that another oddity noticed by @sitter last week was caused by this as well (going by the installedFiles data being out of sync, it would seem likely it would cause what they were seeing). So... while it feels a bit odd, i would have to vote to revert immediately, and create a new patch documenting why we can't detach in certain classes... Possibly adding in a TODO for Frameworks 6 (there's already a couple of those in kns). REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7194 To: apol, leinir Cc: sitter, kossebau, whiting, mutlaqja, broulik, #frameworks
