elvisangelaccio added inline comments. INLINE COMMENTS
> madcatx wrote in kio_smb_browse.cpp:521 > Yes. The idea is this: When the slave loads, it checks what libsmbclient lib > is available and sets the `m_enableEEXISTWorkaround` if a broken version is > detected. Then iff the return code from `smbc_opendir()` is EEXIST and the > `m_enableEEXISTWorkaround` is true EEXIST is treated as EACCES or EPERM. > This should hopefully prevent any weird behavior when EEXIST might be a valid > return code. Do you still think that the method that does this "apply the > workaround" logic could use a better name? I see, basically checking and applying the workaround are the same thing in this case. I guess leave this name, can't think of a better one. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D8387 To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks Cc: graesslin, z3ntu
