gregormi added a comment.
> @ltoscano, can we commit this? Hi Nate, thanks for pushing this forward. > I still disagree in the way this is done, as it means manually periodically updating the information and it's definitely not the right thing to do. Hi Luigi, I agree with you that the manual updating process is not good. As the library was written, there was no better way. The desktop file method was chosen because it was said that they avoid duplicate translation work. See last point of the Introduction https://api.kde.org/frameworks/knewstuff/html/classKMoreTools.html ("Reduce translation effort by re-using .desktop files of the services added to the menu."). Since the goal of KMoreTools is to present applications that are not installed, I currently see no other way to ship all the desktop files. > That said, if @elvisangelaccio approves this, it can go in as temporary fix but the next update should work on using the appstream library to get those information from appstream files. Or any other solutions which does not involve duplicating the information. I looked at the appstream documentation but I was not able to extract information that would help me to understand how to use it in the KMoreTools case. To be of use in KMoreTools there should be an offline database with all needed applications and descriptions. How will this database be filled with new applications? Maybe you can point me to some suitable documentation? > I had tested the patch and it was fixing the bug. > I'm fine with this as long as @gregormi volunteers to maintain this code updated (and eventually to switch to a better design, if possible). Hi Elvis, thanks for testing. Yes, I am currently volunteering to maintain. The library was created to keep application code (like Dolphin) clean of such details. I am regularly looking for a better design. Input welcome. > I'm afraid this doesn't merge cleanly onto master. @gregormi, can you rebase it against current master so that I can merge it? OK, I will rebase onto master and report back when done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: ngraham, ltoscano, #frameworks
