graesslin added inline comments.

INLINE COMMENTS

> desktopfileparser.cpp:547
> +
> +            for(const auto &service : deserializeList(value)) {
>                  // some .desktop files still use the legacy ServiceTypes= key

Be careful with for and qt containers. This causes a detach. Either use the old 
variant or wrap the list in qAsConst ( which is new in 5.7)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D8002

To: mpyne, #frameworks
Cc: graesslin

Reply via email to