dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land.
Looks good. To nitpick, setAutoDeletePlugin(true) would have been clearer IMHO. (Shared sounds like shared_ptr i.e. refcounting, which isn't the case here, it's just autodelete=off) REPOSITORY R286 KFileMetaData BRANCH fixPluginDelete REVISION DETAIL https://phabricator.kde.org/D7750 To: mgallien, #frameworks, dfaure Cc: dfaure, anthonyfieroni
