dhaumann added a comment.
@rjvbb you are changing the memory layout of instances of this class. All applications that use this class / library will break without recompiling. The KDE Frameworks guarantee binary compatibility backwards. See: https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B To get more familiar with this topic, I can also recommend to watch: https://m.youtube.com/watch?v=PHrXGHDd9no In short: there are very strict rules of what you can do with public (=exported, =visible) C++ classes. And adding virtual functions is on the blacklist :) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8043 To: rjvbb, #frameworks, mwolff, dfaure Cc: dhaumann, cfeck, dfaure, mwolff, kde-frameworks-devel
