davidedmundson added a comment.
I think it's important that KStandardGuiItem::discard matches QDialogButtonBox::Discard You've cited what Qt does, but we override it in kstyle.cpp:374 with dialog-cancel If we go with this (and I really don't object) we should adjust KStyle too. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8029 To: ngraham, #frameworks, #vdg, dfaure, rkflx, davidedmundson Cc: cfeck, #frameworks
