kfunk added a comment.
Could someone fluent in QtScript/QtQML review this so we can merge it? INLINE COMMENTS > ktranscript.cpp:96 > // Interface functions. > - Q_INVOKABLE QScriptValue load(); // actually has variable length > argument list > - Q_INVOKABLE QScriptValue setcall(const QScriptValue &name, const > QScriptValue &func, > - const QScriptValue &fval = > QScriptValue::NullValue); > - Q_INVOKABLE QScriptValue hascall(const QScriptValue &name); > - Q_INVOKABLE QScriptValue acall(); // actually has variable length > argument list > - Q_INVOKABLE QScriptValue setcallForall(const QScriptValue &name, const > QScriptValue &func, > - const QScriptValue &fval = > QScriptValue::NullValue); > - Q_INVOKABLE QScriptValue fallback(); > - Q_INVOKABLE QScriptValue nsubs(); > - Q_INVOKABLE QScriptValue subs(const QScriptValue &index); > - Q_INVOKABLE QScriptValue vals(const QScriptValue &index); > - Q_INVOKABLE QScriptValue msgctxt(); > - Q_INVOKABLE QScriptValue dynctxt(const QScriptValue &key); > - Q_INVOKABLE QScriptValue msgid(); > - Q_INVOKABLE QScriptValue msgkey(); > - Q_INVOKABLE QScriptValue msgstrf(); > - Q_INVOKABLE QScriptValue dbgputs(const QScriptValue &str); > - Q_INVOKABLE QScriptValue warnputs(const QScriptValue &str); > - Q_INVOKABLE QScriptValue localeCountry(); > - Q_INVOKABLE QScriptValue normKey(const QScriptValue &phrase); > - Q_INVOKABLE QScriptValue loadProps(); // actually has variable length > argument list > - Q_INVOKABLE QScriptValue getProp(const QScriptValue &phrase, const > QScriptValue &prop); > - Q_INVOKABLE QScriptValue setProp(const QScriptValue &phrase, const > QScriptValue &prop, const QScriptValue &value); > - Q_INVOKABLE QScriptValue toUpperFirst(const QScriptValue &str, const > QScriptValue &nalt = QScriptValue::NullValue); > - Q_INVOKABLE QScriptValue toLowerFirst(const QScriptValue &str, const > QScriptValue &nalt = QScriptValue::NullValue); > - Q_INVOKABLE QScriptValue getConfString(const QScriptValue &key, const > QScriptValue &dval = QScriptValue::NullValue); > - Q_INVOKABLE QScriptValue getConfBool(const QScriptValue &key, const > QScriptValue &dval = QScriptValue::NullValue); > - Q_INVOKABLE QScriptValue getConfNumber(const QScriptValue &key, const > QScriptValue &dval = QScriptValue::NullValue); > + Q_INVOKABLE QJSValue load(QString name); // FIXME? used to have variable > length argument list > + Q_INVOKABLE QJSValue setcall(const QJSValue &name, const QJSValue &func, Consistency: Use `const QString &` REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D7033 To: carewolf, ilic Cc: dhaumann, ltoscano, kfunk, #frameworks
