maxrd2 added inline comments.
INLINE COMMENTS
> krunproxy.cpp:48
> KService::Ptr service = KService::serviceByDesktopPath(filePath);
> return KRun::runService(*service, QList<QUrl>(), nullptr) != 0;
> } else {
While I'm at it should i also change to runApplication() here?
> krunproxy.cpp:57
> + KService::Ptr service = KService::serviceByDesktopName(serviceName);
> + if(service && service->isApplication())
> + return KRun::runApplication(*service, QList<QUrl>(), nullptr) != 0;
Am not sure if service->isApplication() check here is needed... can someone
confirm please?
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2, davidedmundson
Cc: broulik, #frameworks
