ilic accepted this revision. ilic added a comment. This revision is now accepted and ready to land.
I'd say the patch is fine as it is. If this code is invoked through an intermediate library, that library's definition of TRANSLATION_DOMAIN will have no effect, instead kross' TRANSLATION_DOMAIN will be used. Therefore if applicationDomain is empty, then there is no place to fetch translation from, and untranslated string should be returned (as it will happen with this patch). Alternatively, in case of empty applicationDomain some sort of warning could be produced. REPOSITORY R317 Kross BRANCH master REVISION DETAIL https://phabricator.kde.org/D7523 To: aacid, ltoscano, ilic, aspotashev Cc: #frameworks
