turbov added a comment.

  In https://phabricator.kde.org/D7175#138554, @dhaumann wrote:
  
  > What is still unclear to me: As I understand we from time to time run the 
generator script (point 2 in my list). So this is not automatically run when 
executing "make", right?
  
  
  correct. it doesn't run on `make` and never was. Some time ago I've imroved 
that generator and know its limitations and pitfals -- yeah, it is too simple 
to "parse" informal (in fact) output of `cmake --help-xxx` commands correctly.
  That is the main goal I pursue doing that redesign -- to make sure that all 
commands and parameters are here (in keyword lists) is not a mistake (error in 
the current generator).
  And most important, at least to me, to highlight only really existed named 
keywords for particular command, giving a hint to a user that particular 
parameter is really exists in this particular command.
  
  > I would be fine with this change, but the other point still stand: remove 
hard-coded colors :-) And do we have a test case for this? If not, please add a 
test file.
  
  yeah, I'll do that as soon as realize that this MR have a chance to be 
accepted... %)
  
  > Also, since you redesign this file, I think it would be OK to relicense to 
MIT.
  
  sure

REVISION DETAIL
  https://phabricator.kde.org/D7175

To: turbov, dhaumann, #kate, #framework_syntax_hightlighting, vkrause
Cc: cullmann, #frameworks

Reply via email to