ltoscano requested changes to this revision. ltoscano added a comment. This revision now requires changes to proceed.
I strongly suggest to port to ecm_qt_declare_logging_category for both the old and the new category. This script can automated the process: https://cgit.kde.org/kde-dev-scripts.git/tree/kf5/convert-qkdebug-to-qcdebug.sh INLINE COMMENTS > testkcd.cpp:66 > { > + qputenv("QT_LOGGING_RULES", QByteArrayLiteral("cd=true")); > QCoreApplication app(argc, argv); Please don't set this here. It can be controlled at runtime. > testkcd.cpp:69 > > - qDebug() << "Testing libKF5CompactDisc"; > + tKCD.setEnabled(QtDebugMsg, true); > + qCDebug(tKCD) << "Testing libKF5CompactDisc"; ditto REPOSITORY R349 KCompactDisc Library REVISION DETAIL https://phabricator.kde.org/D7380 To: rjvbb, #frameworks, davidedmundson, ltoscano Cc: ltoscano, davidedmundson
