mpyne created this revision. Restricted Application added a project: Frameworks.
REVISION SUMMARY Inspired by https://phabricator.kde.org/D7279, manually declare nested Private classes to have hidden visibility (by default, they inherit the visibility of the class that they are nested under). This removes the private symbols from the resulting .so (I've verified this myself) although it's only a micro-optimization with regard to binary size. TEST PLAN All autotests continue to pass, no additional build warnings. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D7281 AFFECTED FILES src/lib/caching/kshareddatacache.cpp src/lib/caching/kshareddatacache_win.cpp src/lib/jobs/kjobtrackerinterface.cpp src/lib/jobs/kjobuidelegate.cpp src/lib/kaboutdata.cpp src/lib/randomness/krandomsequence.cpp src/lib/util/kdelibs4configmigrator.cpp src/lib/util/kuser_unix.cpp src/lib/util/kuser_win.cpp To: mpyne, #frameworks
