mpyne created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
As reported in bug 310674, the Desktop Entry spec says that whitespace
surrounding the `=` sign that separates the key and value in .desktop files
should be ignored when interpreting the key and value portions.
That is, all four of these lines should be equivalent:
Type=Application
Type =Application
Type= Application
Type = Application
KConfigIni already handles this for the key (by calling `.trim` on the value
that is assigned to `aKey`), but neglects to do so for the value. This patch
fixes this so that reading .desktop files through KConfigIni should be
standards-compliant.
TEST PLAN
The patch includes a modification to the existing autotests which fail with
the old code, and pass with the updated code. A separate test is not added,
but instead I added spaces to parts of the existing test .desktop files, as
this is enough to exercise the new code.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D7169
AFFECTED FILES
autotests/kdesktopfiletest.cpp
src/core/kconfigini.cpp
To: mpyne, #frameworks
