dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  A good patch, and adding new non-virtual functions is binary compatible. So 
this looks good to me.

INLINE COMMENTS

> ksqueezedtextlabel.h:110
> +     * i.e. the original text does not fit inside the space
> +     * available and elide mode is not Qt::ElideNone.
> +     *

Suggestion:  "and elide mode is set to a value other than Qt::ElideNone" ?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7162

To: rkflx, #frameworks, dhaumann
Cc: dhaumann

Reply via email to