cfeck added a comment.
Looks good to go from my side. Let's wait a bit if someone has more objections. Thanks Laurent, it was a needed change considering the code duplication that was present before. REVISION DETAIL https://phabricator.kde.org/D7011 To: mlaurent, cfeck, dfaure, elvisangelaccio Cc: kfunk, kossebau, elvisangelaccio, #frameworks