apol added inline comments.
INLINE COMMENTS
> conanfile.py:3
> +
> +class KarchiveConan(ConanFile):
> + name = "KArchive"
`KArchiveConan`?
> conanfile.py:5
> + name = "KArchive"
> + version = "5.37.0-git"
> + license = "lgpl2"
Can we re-use the version from the `CMakeLists.txt`?
> conanfile.py:7
> + license = "lgpl2"
> + url = "<Package recipe repository url here, for issues about the
> package>"
> + settings = "os", "compiler", "build_type", "arch"
Re-use from metainfo.yml?
> conanfile.py:9
> + settings = "os", "compiler", "build_type", "arch"
> + options = {"shared": [True, False]}
> + default_options = "shared=True"
I don't understand what this means :(
> conanfile.py:4
> +
> +class KarchiveTestConan(ConanFile):
> + settings = "os", "compiler", "build_type", "arch"
`KArchiveTestConan`
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D6877
To: gladhorn
Cc: apol, cfeck, #frameworks
