leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land.
That is indeed a very good point. I think we might possibly have an issue here, though, in that since these two searches are no longer stand-alone, if the filter is not explicitly reset before attempting to perform a search we will only search installed and updateable items. I don't think it is necessarily an enormous or insurmountable issue here, as far as i can tell the only code which currently uses these two functions is in KNS' own DownloadManagers (at least, lxr suggests as much), and if we ensure those two are fixed to reset the filter before launching a search, i think we're probably ok. PS: These two functions also lack documentation, which shall need fixing (though not necessarily as a part of this D) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D6492 To: apol, #frameworks, leinir
