kfunk added a comment.
A couple of minor issues I spotted while looking briefly over the patch.
INLINE COMMENTS
> kateviewinternal.cpp:76
> +
> + bool detectZoomingEvent(QWheelEvent *e, Qt::KeyboardModifiers
> modifier=Qt::ControlModifier)
> + {
Style: Use ` = `
> kateviewinternal.cpp:85
> + if (m_lastWheelEventUnmodified && deltaT < 200) {
> + m_ignoreZoom = true;
> + }
Style: Indent off
> kateviewinternal.cpp:87
> + }
> + else {
> + // the protection is kept active for 1s after the last
> wheel event
Simplify: `else if (...) {`?
> kateviewinternal.cpp:121
> + QElapsedTimer m_lastWheelEvent;
> + bool m_ignoreZoom;
> + bool m_lastWheelEventUnmodified;
Initialize here
> kateviewinternal.cpp:122
> + bool m_ignoreZoom;
> + bool m_lastWheelEventUnmodified;
> +};
Dito
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5037
To: rjvbb, #ktexteditor
Cc: kfunk, luebking, anthonyfieroni, dhaumann, kwrite-devel, #ktexteditor,
#frameworks, head7, cullmann, sars
