leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land.
Sorting correctness (and more thorough testing) is good, yes. LGTM! :) As to the missing arcconfig... will need someone to produce one of those who actually uses arc to fix that ;) Removing the .reviewboardrc, though, sounds like a good idea in general. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D6049 To: adridg, whiting, #frameworks, leinir Cc: leinir, #frameworks
