apol added inline comments. INLINE COMMENTS
> README.md:30 > + > + find_package(KF5NewStuffCore NO_MODULE) # for the KNewStuffCore library > only > + find_package(KF5NewStuff NO_MODULE) # for the KNewStuff UI library, will > pull in KNewStuffCore for you I'd say that it looks better to have `CONFIG` rather than `NO_MODULE`. Both should work. Also `find_package(KF5 COMPONENTS NewStuffCore)` reads better to my eye. > README.md:35 > +(or similar) in your CMakeLists.txt file, and you need to link to > KF5::NewStuff, > +KF5::NewStuffCore or KF5::NewStuffQuick > + Do you ever need to link against `NewStuffQuick`? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5902 To: leinir, #knewstuff Cc: apol, #frameworks
