sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.
Note that there's still an ordering problem with the new fetch-translations
target now. The {ts,po}files-* targets can run before the fetch-translations
target so on first run you may have no `BINDIR/po` directory yet, if
`KDE_L10N_AUTO_TRANSLATIONS` was use anyway. make 👉 `pofiles-123abc` runs and
does nothing on account of the dir not existing 👉 `fetch-translations` runs
creating the dir 👉 pofiles haven't been made.
I am not sure how to best solve this but I guess you'll need an `if target
fetch-translations; add_dependencies(fetch-translations pofiles)` or somesuch.
Not really a problem with the change though, so this is good enough for
landing for me. Still would prefer if it had tests though :P
REPOSITORY
R249 KI18n
BRANCH
fetchbuildtime
REVISION DETAIL
https://phabricator.kde.org/D5167
To: apol, #frameworks, sitter, ltoscano, ilic
Cc: aacid
