aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land.
Makes sense, the other option would be actually erroring out as we do in check_compiler_version if you don't run "the correct clang/gcc", but i guess this may be enough for MSVC at this point. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5489 To: kfunk, aacid, bcooksley Cc: #frameworks, #build_system