kossebau added inline comments. INLINE COMMENTS
> ltoscano wrote in kaboutdata.cpp:689 > I think that any extra unneeded step is only prone to produce issues. > In 90% of the cases (and probably more, like basically all stuff on kde.org), > the desktop file name is org domain + component. No need to do it again and > again. A flag is a minimal price to pay, if needed. Maybe it's not even > needed, because you can compute it on the fly (if not set, return org domain > + component, if both set). > So yes, I'd like a reminder here. > At least > // KF6: evaluate if desktopFileName can return org domain + component if not > explicitly set. Isn't the KF6 comment added in KAboutData::desktopFileName() not already doing that, more or less? Not sure what you exactly ask for. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D5439 To: kossebau, #frameworks, stikonas, mpyne, aacid, ltoscano Cc: dfaure
