dfaure added a comment.

  Good point, I added a destructor to KIOD now, please try again ;)

INLINE COMMENTS

> kioexecd.cpp:54
> +{
> +    const auto files = m_watched.keys();
> +    for (const auto &file : files) {

btw iterating over keys() is bad practice (slow because it requires creating 
and filling a temporary container first). Better use a proper QMap iterator.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D5030

To: elvisangelaccio, dfaure
Cc: #frameworks

Reply via email to