kossebau added a comment.

  In https://phabricator.kde.org/D3987#95858, @kfunk wrote:
  
  > Closing. This Diff refactored the code technically correct.
  
  
  Technically correct, as in: it builds.
  But semantically it is incorrect and a regression when it comes to flags, 
especially as high level languages are made for humans in the first line, not 
compilers ;)
  
  > If you want to replace `MyFlags flags = nullptr` by `... = {}` please do so 
in a follow-up patch/review.
  
  Seems you do not see yourself in the duty to do the fix-up. so I have to 
scratch this itch myself, tss :)
  So please tell what tools you used to create this diff, so I could have a 
look how I can reuse them for fixing all the `MyFlags flags = nullptr` by `... 
= {}`? Any suggestions how that could be done best?

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D3987

To: kfunk, #frameworks, dfaure, kossebau
Cc: skelly, kossebau, dfaure, graesslin

Reply via email to