apol added inline comments.

INLINE COMMENTS

> theme_p.cpp:221
> +
> +            for (const QString &file : cacheDir.entryList()) {
>                  if (currentCacheFileName.isEmpty() ||

Use entryInfoList? This way you won't have to construct the path again...

> theme_p.cpp:270
> +
> +        for (const QString &file : cacheDir.entryList()) {
> +            if (!file.endsWith(svgElementsFileName)) {

Same

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4925

To: mart, #plasma
Cc: apol, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Reply via email to