apol added a comment.
autotests would be very welcome! INLINE COMMENTS > transaction.cpp:134 > + > + const QVector<quint64> children = docUrlDB.getChildren(parentId); > + Return right away? > apol wrote in metadatamover.cpp:49 > const auto & Uh you are right, no need for a const&, I assumed it were QString for some reason. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D4911 To: mgallien Cc: apol, #frameworks
