dfaure added inline comments. INLINE COMMENTS
> mwolff wrote in kdirwatch.cpp:371 > future patch should hoist that out of the loop to not rely on the compiler to > do our job Good point. > mwolff wrote in kdirwatch_p.h:84 > instead of commenting it out, =default them? Given that the same thing happens by default, what would be the reason to make it explicit? > mwolff wrote in kdirwatch_p.h:141 > so.. the client is copyable, no? If so, returning a vector<Client> here as > well would be much nicer, no? The fact that it *can* be copied, doesn't mean that it's better to copy, performance wise ;) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4584 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, aacid, mpyne Cc: mwolff, #frameworks
