dfaure added inline comments.
INLINE COMMENTS
> kcompressiondevice.cpp:208
> + // asked us to be in
> + if (!QIODevice::seek(d->deviceReadPos)) {
> + return false;
I wonder if we could avoid seeking twice, by doing seek(pos) only in the other
cases (the deviceReadPos ==pos early return, and the pos == 0 case above).
We don't need the seek(pos) in this if(), nor in the else().
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D4437
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: aacid, dfaure
Cc: #frameworks
