----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129842/#review102296 -----------------------------------------------------------
Ping? - Elvis Angelaccio On Jan. 15, 2017, 5:10 p.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129842/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2017, 5:10 p.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: kauth > > > Description > ------- > > This moves most of the example snippets (which were outdated) into real cmake > targets. We use the Doxygen `@snippet` magic to show them in the apidox. This > ensures that the example code is always compiled and stays up-to-date. > Some of the snippets are just removed, in particular the section about > executing the actions asynchronously, which predates the KJob (ExecuteJob) > usage. > > > Diffs > ----- > > CMakeLists.txt 58d0f2a5d6c2f442097a27e229a1b8cb3ec35f73 > examples/CMakeLists.txt PRE-CREATION > examples/client.cpp PRE-CREATION > examples/helper.cpp PRE-CREATION > metainfo.yaml f709143c00d70c834d6ccde103f575be3771d448 > src/kauthactionreply.h 6203df034483c102eb82220cca3dac313a094f41 > > Diff: https://git.reviewboard.kde.org/r/129842/diff/ > > > Testing > ------- > > Examples targets build fine. > Ran kapidox locally, code snippets shows up in the documentation of the KAuth > namespace. > > > Thanks, > > Elvis Angelaccio > >
