----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129870/#review102189 -----------------------------------------------------------
Ship it! lgtm, and I doubt that emoticons play a role for kate/kdevelop/krita or anything else on windows where dbus is usually disabled? - Milian Wolff On Jan. 22, 2017, 11:48 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129870/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2017, 11:48 a.m.) > > > Review request for KDE Frameworks and Milian Wolff. > > > Repository: kemoticons > > > Description > ------- > > My recent performance fix stopped KEmoticons from reparsing kdeglobals > at ever call to currentThemeName(), which means that now we need to know > when to reparse. But actually by using a dbus signal we can just ship the > information in the signal, so no config file reparsing is needed. > > > Diffs > ----- > > CMakeLists.txt 58e57afe6c038b6491f2f163365ef6becb0214b3 > src/core/CMakeLists.txt 51d369a4333024806e28b92d4e7d471eb96e516a > src/core/kemoticons.cpp bb59d170720df7f0ee3cee20649a43e3f1f4440f > src/core/kemoticonsglobal.cpp PRE-CREATION > src/core/kemoticonsglobal_p.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129870/diff/ > > > Testing > ------- > > Changing the emoticons theme in `kcmshell5 emoticons` while KMail is running. > Then switching to another message in KMail uses the newly selected icon > theme, without having to restart kmail. > > > Note: the "new" dependency on QtDBus isn't new, KEmoticons uses KService > which depends on DBus already. > > > Thanks, > > David Faure > >
