----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129860/#review102125 -----------------------------------------------------------
Ship it! >From looking at the code, m_started can only be true when m_widget != 0, but >doesn't hurt to check both. - Christoph Feck On Jan. 20, 2017, 11:37 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129860/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2017, 11:37 p.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kwidgetsaddons > > > Description > ------- > > "No frame loaded", when starting Qt designer > > > Diffs > ----- > > autotests/CMakeLists.txt 166346fd9c685b9257a2ccf39ce7077c0a94d0ec > autotests/kpixmapsequencewidgettest.cpp PRE-CREATION > src/kpixmapsequenceoverlaypainter.cpp > e817298d6c3a058fbceb7391bedf8c262fcf9ce3 > > Diff: https://git.reviewboard.kde.org/r/129860/diff/ > > > Testing > ------- > > Added (the most basic ever) unittest, no warning anymore. > > > Thanks, > > David Faure > >
