-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129856/
-----------------------------------------------------------
(Updated Jan. 20, 2017, 9:21 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, Martin Klapetek, Harald Sitter, and Volker
Krause.
Changes
-------
Submitted with commit 16675c710f343e8a0db69dd4248681144015b14f by David Faure
to branch master.
Repository: kemoticons
Description
-------
Don't parse kdeglobals every time KEmoticons::theme() is called.
KSharedConfig is only efficient if something keeps a refcount on it,
which is typically not the case for KSharedConfig::openConfig("kdeglobals").
So use the default-constructed KSharedConfig instead, for this.
Found by interrupting kmail in gdb, KTextToHTMLEmoticons::parseEmoticons
(used by MimeTreeParser) calls KEmoticons::theme().
Interestingly this problem was already mentioned in a commit message from
Volker in 2015 ;)
Diffs
-----
src/core/kemoticons.cpp 0e216af7b871a99e6265ec43783904772953f824
Diff: https://git.reviewboard.kde.org/r/129856/diff/
Testing
-------
It compiles and the existing unittests in kemoticons still pass. That's
something, already :)
Thanks,
David Faure
