I've actually switched all activity to KDE/master (I'm presently on a5f3a76e14799c68b5e8f74e375baa5f6f6ab4dc), so I'll check again when I've got your latest updates. BTW, one other thing I noticed was this, if I "make clean" in kguiaddons, src/sip/PyKF5/KGuiAddons/KGuiAddonsmod.sip is not removed. It is only ever created when cmake is run.
Is this as expected? On 18 January 2017 at 21:16, Stephen Kelly <steve...@gmail.com> wrote: > On 01/18/2017 12:41 PM, Shaheed Haque wrote: > > Hi Steve, > > > > I have verified this works on KDE/master, and will close the review. > > > > I did see a "funny" in that I had to run CMake twice in a fresh > > directory before it would run clean. You might want to look into that > > as it was not clear to me what it CMake is trying to do. Anyway, here > > is the first unsuccessful run: > > Hi Shaheed, > > I somehow made my frameworks-bindings repo point to incorrect old sha1s > for frameworks. I've fixed that now, so you should be able to build all > of them with a clean build. > > Thanks, > > Steve. > > >
