kossebau created this revision. kossebau added a reviewer: Frameworks. Restricted Application added a project: Frameworks.
REVISION SUMMARY KConfigDialogManager was possibly designed when there was no way to access the change signal of properties. So maintaining the signals and properties to use in separate global user-accessable tables might have been done as there was no other option. But this has flaws: - prevents per-widget-instance settings - different libs & plugins might do conflicting settings - requires explicit setup With modern Qt metaobject API instead the change signal can be fetched and used automatically. For backward-compatibility in KF5 this will be only a new option, those global maps should be removed on next ABI breakage. TEST PLAN Old and new tests do not fail. REPOSITORY R265 KConfigWidgets BRANCH readChangeSignalFromMetaObject REVISION DETAIL https://phabricator.kde.org/D4130 AFFECTED FILES autotests/kconfigdialog_unittest.cpp src/kconfigdialogmanager.cpp src/kconfigdialogmanager.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks
