----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129641/ -----------------------------------------------------------
(Updated Jan. 8, 2017, 6:58 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks, Dan Leinir Turthra Jensen and Jeremy Whiting. Changes ------- Submitted with commit c7addf185a51bc88280f06e3edc327c3049dbec7 by Kai Uwe Broulik to branch master. Repository: knewstuff Description ------- Hiding the button in the first place is prettier than presenting the user with an error when he or she clicks on it. Diffs ----- src/button.cpp 9606171 Diff: https://git.reviewboard.kde.org/r/129641/diff/ Testing ------- Ported KWin's script KCM to use GHNS Button (D3647) and the button hid itself with [KDE Action Restrictions] ghns=false Unfortunately, there's no QML equivalent, so we either need to come up with one or fix all the KCMs and Plasma manually :/ Thanks, Kai Uwe Broulik