dfaure added a comment.
Well, both ;) Martin's commit landed after the change to nullptr even though it was initially written before that change so it wasn't ready for it -> I just fixed it in https://commits.kde.org/kconfig/d3de5a2a79d2786207d0cfbbc9828e00dabd148d However I see more failures here : 12/35 Test #12: kconfiggui-kconfigskeletontest ...............***Failed 0.12 sec - Start testing of KConfigSkeletonTest ********* Config: Using QtTest library 5.8.0, Qt 5.8.0 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 4.8.5) PASS : KConfigSkeletonTest::initTestCase() FAIL! : KConfigSkeletonTest::testSimple() Compared values are not the same Loc: [/d/kde/src/5/frameworks/kconfig/autotests/kconfigskeletontest.cpp(79)] FAIL! : KConfigSkeletonTest::testDefaults() Compared values are not the same Actual (mMyBool) : 1 Expected (DEFAULT_SETTING1): 0 REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D3702 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, davidedmundson Cc: aacid, graesslin, dfaure
