kfunk added a comment.
In https://phabricator.kde.org/D2075#66751, @jonathans wrote: > Agreed that would be more robust. In writing the patch I was seeking consistency with those functions that already did the test, so those would also need to be updated. Are there any situations where the two tests would yield a different result, ie d->native is true and d->w is non-null? Probably not. But I think it makes more sense to check the pointer you're actually going to dereference in the next statement. Could you update the patch? And also fix the `nullptr` issues? REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D2075 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jonathans, #frameworks, dfaure, kfunk Cc: kfunk, aacid
