----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129625/ -----------------------------------------------------------
(Updated Dec. 8, 2016, 10:50 a.m.) Review request for KDE Frameworks and David Faure. Changes ------- Fixed issues and updated the ERR_CANNOT_LAUNCH_PROCESS case in rawErrorDetail(). Repository: kio Description ------- This patch is an attempt to fix this ugly error message: http://i.imgur.com/26Y6Xix.png The problem is that in KIO::buildErrorString() the ERR_CANNOT_LAUNCH_PROCESS case assumes that the `errorText` starts with the name of a process (example usage in [kio_smb](https://lxr.kde.org/source/kde/kdenetwork/kio-extras/smb/kio_smb_mount.cpp#0110)). However, Slave::createSlave() also uses ERR_CANNOT_LAUNCH_PROCESS but with "self-contained" error messages, which results in the unfortunate screenshot above. There is no easy way to fix this without breaking the error messages from the client slaves, so I propose to add a new error code ERR_CANNOT_CREATE_SLAVE which is used only by Slave::createSlave() (at least for now). Diffs (updated) ----- src/core/global.h 3d38436fbe28f4236b6ca34a651c1805295c02f2 src/core/job_error.cpp a67954cc44be6994992167700315321761ce0528 src/core/slave.cpp 4690ed50d3f5d28bdaeee84f85107ab75cfab555 Diff: https://git.reviewboard.kde.org/r/129625/diff/ Testing ------- See screenshots before/after. File Attachments ---------------- Before https://git.reviewboard.kde.org/media/uploaded/files/2016/12/07/a4a6468a-0376-4979-9af0-8a11229acf69__26Y6Xix.png After https://git.reviewboard.kde.org/media/uploaded/files/2016/12/07/b534602e-39eb-44bf-915d-046110ed0e78__Screenshot_20161207_194933.png Thanks, Elvis Angelaccio
