> On Dec. 3, 2016, 1:28 p.m., Martin Gräßlin wrote: > > As the one who did the mentioned change: -1 to this > > > > Please note that this change was done in coordination with the usability > > group. So please add our usability experts to this review request. > > Martin Gräßlin wrote: > I think I should explain a little bit more why I give a -1 to this. > > First of all there was a reason to move the version information into a > dedicated tab. If we now see that this was a bad move, then we need to go a > step back and re-evaluate why the step was done and what would be a better > solution. > > Then what I absolutely dislike in the screenshot is that it lists > "Version" twice. From a UI perspective I think that is really bad and > confusing. The minimum needed change would be a rename of the Version tab and > also remove the Version from the Version tab. > > Furthermore I want to mention that an idea back then was to add API which > allows to fine tune the Version tab for the application, to allow adding > further information. > > Also to consider here is whether the version information is really that > important for all our applications to be that prominent. I see that for your > case that's true, but honestly I doubt it. The version information is not > that important in general and one click more is not that bad. Others might > think that frameworks version is so important that it needs to be prominent > and some might say that the Qt version is absolutely important. We cannot add > everything there. So is it really that important? > > We have many applications where the version information is hardly of > interest. Example would be all applications from Plasma on e.g. KDE Neon. The > version number is the same as the operating system. It's not important at > all. That's clearly something to consider here.
and please also add sebas to the review. He mostly drove the design of this change by sitting next to me while I implemented it and gave valuable feedback. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/#review101229 ----------------------------------------------------------- On Dec. 3, 2016, 1:29 p.m., Jean-Baptiste Mardelle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129607/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2016, 1:29 p.m.) > > > Review request for KDE Frameworks and KDE Usability. > > > Repository: kxmlgui > > > Description > ------- > > Last year, a change in kaboutapplicationdialog (review 124133) moved the > application version in a separate tab. However for applications, it is really > annoying (several Kdenlive users complained and I fully agree) to not have > this information clearly displayed as soon as the About dialog is displayed. > I understand the interest of having a separate version tab displaying the > various underlying libraries used, but I propose to display again the > application version in the About dialog header (see screenshot). > > > Diffs > ----- > > src/kaboutapplicationdialog.cpp 156410e > > Diff: https://git.reviewboard.kde.org/r/129607/diff/ > > > Testing > ------- > > Reverts a recent change, tested and works. > > > File Attachments > ---------------- > > About dialog with version > > https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png > > > Thanks, > > Jean-Baptiste Mardelle > >
