-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129395/#review101129
-----------------------------------------------------------




src/widgets/kpropertiesdialog.cpp (line 3482)
<https://git.reviewboard.kde.org/r/129395/#comment67776>

    same comment as in 129399, it would be good if only the first properties 
dialog was slowed down by this dbus call, if the value can't change.


- David Faure


On Nov. 22, 2016, 12:06 p.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129395/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 12:06 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This patch adds option to run certain application on a discrete graphics card 
> (if there is any). I also modified KRun::runApplicationImpl() to take this 
> option into account when running application.
> 
> 
> Diffs
> -----
> 
>   src/widgets/kpropertiesdesktopadvbase.ui 4d2a73d 
>   src/widgets/kpropertiesdialog.cpp 653383b 
> 
> Diff: https://git.reviewboard.kde.org/r/129395/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot of KPropertiesDialog
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/14/89203f95-9267-47db-b2ad-0eeb42357a1c__kpropertiesdialog.png
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Reply via email to